[Bug 53180] New: DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method

https://issues.apache.org/bugzilla/show_bug.cgi?id=53180

          Priority: P2
            Bug ID: 53180
          Assignee: [hidden email]
           Summary: DefaultInstanceManager#populateAnnotationsCache -
                    incomplete check is used when validating for a setter
                    method
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: [hidden email]
          Hardware: All
            Status: NEW
           Version: 7.0.27
         Component: Catalina
           Product: Tomcat 7

Created attachment 28711
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28711&action=edit
Patch proposal

Hi,

In org.apache.catalina.core.DefaultInstanceManager#populateAnnotationsCache,
when iterating over methods in a given class, in one of the cases (when
injection-target is specified) you validate whether the method is a valid
setter method. In my opinion the check that is used for that validation is not
complete.
I would like to propose a patch (attached) that introduces additional checks in
order to guarantee that the corresponding method is really suitable to be an
injection target.

I'm looking forward to your commends.

Best Regards
Violeta Georgieva

--
You are receiving this mail because:
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=53180

Violeta Georgieva <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28711|0                           |1
           is patch|                            |
  Attachment #28711|application/octet-stream    |text/plain
          mime type|                            |

--
You are receiving this mail because:
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=53180

Mark Thomas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Mark Thomas <[hidden email]> ---
Patch looks good to me. Applied to trunk and 7.0.x and will be included in
7.0.28 onwards.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53180

--- Comment #2 from Violeta Georgieva <[hidden email]> ---
Thanks
Violeta

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]