[Bug 53267] New: The JreMemoryLeakPreventionListener causes a full GC every hour when gcDaemonProtection=true

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

          Priority: P2
            Bug ID: 53267
          Assignee: [hidden email]
           Summary: The JreMemoryLeakPreventionListener causes a full GC
                    every hour when gcDaemonProtection=true
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: [hidden email]
          Hardware: All
            Status: NEW
           Version: trunk
         Component: Catalina
           Product: Tomcat 7

Created attachment 28809
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28809&action=edit
Increases timeout on sun.misc.GC.requestLatency in
JreMemoryLeakPreventionListener

The JreMemoryLeakPreventionListener causes a full GC every hour when
gcDaemonProtection=true.

The prevention technique invokes sun.misc.GC.requestLatency with a value of
360000.  Increasing the value to Long.MAX_VALUE would be beneficial.

The attached patches add a default setting of Long.MAX_VALUE (add documentation
update), but also permit it to be configured to a lower value using a System
property.

--
You are receiving this mail because:
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #1 from Pid <[hidden email]> ---
Created attachment 28810
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28810&action=edit
Docs patch for JreMemoryLeakPreventionListener.

--
You are receiving this mail because:
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

Leon Rosenberg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

Konstantin Kolinko <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28809|0                           |1
           is patch|                            |
  Attachment #28809|application/octet-stream    |text/plain
          mime type|                            |

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #2 from Konstantin Kolinko <[hidden email]> ---
For reference, a thread on users list about observing this issue with 6.0.28,
"JreMemoryLeakPreventionListener and hourly Full GC" (2010-08):

http://marc.info/?t=128156139600002&r=1&w=2
http://markmail.org/thread/53rxdqyqnjhlzk6d

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #3 from Konstantin Kolinko <[hidden email]> ---
As far as I can see, Long.MAX_VALUE in s.m.GC is treated specially, and I
suspect that using this specific value may break the memory leak prevention
feature.

I am OK with making the latency configurable, though I think it is better to
just add a property on this listener class, instead of a system property.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

Mark Thomas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #4 from Mark Thomas <[hidden email]> ---
Moving this to bug status rather than enhancement.

I need to review the JVM code again but I suspect using Long.MAX_VALUE-1 would
achieve what was originally intended.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

Mark Thomas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Mark Thomas <[hidden email]> ---
Fixed in trunk and 7.0.x and will be included in 7.0.28. By default, a full GC
will now occur roughly every 290 million years.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #6 from Christopher Schultz <[hidden email]> ---
(In reply to comment #5)
> Fixed in trunk and 7.0.x and will be included in 7.0.28. By default, a full
> GC will now occur roughly every 290 million years.

Then it's probably going to be a big one.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #7 from [hidden email] ---
Is this bug fix going to be backported to Tomcat 6.x?

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #8 from Konstantin Kolinko <[hidden email]> ---
I proposed backport of r1343895 for 6.0.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #9 from Konstantin Kolinko <[hidden email]> ---
Fixed in 6.0 in r1347072 and will be in 6.0.36.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #10 from Filip Hanik <[hidden email]> ---
Configurable value added in r1377543

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

--- Comment #11 from Konstantin Kolinko <[hidden email]> ---
(In reply to comment #10)
> Configurable value added in r1377543

Reverted in r1378132, based on "Re: svn commit: r1377689" discussion on dev@,
http://tomcat.markmail.org/thread/6hmjgrzys5txekew

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]