[Bug 64149] New: NullPointerException in AbstractAccessLogValve

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 64149] New: NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

            Bug ID: 64149
           Summary: NullPointerException in AbstractAccessLogValve
           Product: Tomcat 9
           Version: 9.0.31
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Catalina
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: -----

Hello,

we have a regression with version 9.0.31, it worked before with 9.0.30.

Cause seems to be this commit:
https://github.com/apache/tomcat/commit/fdcb3656239065654909ca55994787c027dbe583#diff-dc73b9f0609a4d3593f8a1f789ac1496


17-Feb-2020 09:45:56.925 SCHWERWIEGEND [catalina-exec-5]
org.apache.coyote.http11.Http11Processor.service Fehler bei der Verarbeitung
der Anfrage
        java.lang.NullPointerException
                at
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:685)
                at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
                at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
                at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:367)
                at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
                at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
                at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1639)
                at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
                at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
                at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
                at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)

Kind regards,
Roland

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64149] NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

Remy Maucherat <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Remy Maucherat <[hidden email]> ---
Please post the configuration.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64149] NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

--- Comment #2 from Roland Wachinger <[hidden email]> ---
Sorry, can't help you with that atm as I don't have access. I'll see what I can
get.

Aside from that, I suppose a null check won't hurt?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64149] NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

--- Comment #3 from Mark Thomas <[hidden email]> ---
We need to find out why the NPE is occurring first. We don't want to mask a
symptom of a bug elsewhere. Better to see the NPE so we know there is a
problem. Hence the request for more info so we can figure out what is going on.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64149] NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

--- Comment #4 from Roland Wachinger <[hidden email]> ---
Created attachment 37118
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37118&action=edit
our server.xml

I attached the server.xml. I think the problem here is one of the valves in the
end. This used to work in 9.0.30.
We also switched the handler to rotatable = false in the logging config, aside
from that it is all defaults.

The problem still persists in 9.0.33

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64149] NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

Remy Maucherat <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #5 from Remy Maucherat <[hidden email]> ---
Ok, I can reproduce and will fix this "issue".

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64149] NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

Remy Maucherat <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Remy Maucherat <[hidden email]> ---
There was a NPE when no pattern is specified. In that case, the valve does
nothing so remove it.
The fix will be in 10.0.0-M4, 9.0.34 and 8.5.54.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64149] NullPointerException in AbstractAccessLogValve

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64149

--- Comment #7 from Roland Wachinger <[hidden email]> ---
Aweseome :) Thank you very much

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]