[Bug 64743] New: When set maxSwallowSizeto -1, the value of connection must be set to close.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 64743] New: When set maxSwallowSizeto -1, the value of connection must be set to close.

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64743

            Bug ID: 64743
           Summary: When set maxSwallowSizeto -1, the value of connection
                    must be set to close.
           Product: Tomcat 8
           Version: 8.5.57
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Packaging
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ----

I set "maxSwallowSize" to -1, in order to unlimited the uploaded file size. But
in 8.5.57 version, I found the following content was inserted into response
header. The most important point is "Connection: close". But the value of
Connection is keepalive in 8.5.56 version.
______________________________________________________
Keep-Alive: timeout=60, max=100
Pragma: requestnum="235"
Content-Type: application/fastinfoset;charset=utf-8
Transfer-Encoding: chunked
Date: Wed, 16 Sep 2020 08:20:40 GMT
Connection: close
Server: WEB
______________________________________________________

So I had a look at changelogs and found tomcat can check the value in 8.5.57
version, when the size of content is larger than the value of maxSwallowSize,
the keepAlive is set to false, so the connection is closed.

So if unlimited the uploaded file size(maxSwallowSize" = -1), the connection
must be closed ?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64743] When set maxSwallowSizeto -1, the value of connection must be set to close.

Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64743

Mark Thomas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Mark Thomas <[hidden email]> ---
That is a regression in the handling of aborted uploads. We need to ignore the
case where maxSwallowSize has been set to less than 0. I'll get this fixed.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[Bug 64743] When set maxSwallowSizeto -1, the value of connection must be set to close.

Bugzilla from bugzilla@apache.org
In reply to this post by Bugzilla from bugzilla@apache.org
https://bz.apache.org/bugzilla/show_bug.cgi?id=64743

Mark Thomas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Thomas <[hidden email]> ---
Fixed in:
- master for 10.0.0-M9 onwards
- 9.0.x for 9.0.39 onwards
- 8.5.x for 8.5.59 onwards

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]