[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva opened a new issue #19: How can I add .groovy file support that do not get converted to .class files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva opened a new issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox

ShamithaSIlva opened a new issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19


   I have Groovy files having .groovy extensions that do not get compiled to .class file even after deployment. But they still have text based entries on those files like: import javax.servlet.http.HttpServletResponse.
   
   Where should I change to add support for such files?
   
   Thanks


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox

markt-asf commented on issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841313392


   That will need a code change. Longer term we might want to think about making this more configurable. For now, give me a few minutes and I'll have a snapshot build you can test...


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox
In reply to this post by GitBox

rmaucher commented on issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841318244


   Ideally, it has to be done magically [this is mandatory for the Tomcat auto deployment migration to work, since there's very little room for configuration] but this looks hard.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox
In reply to this post by GitBox

markt-asf commented on issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841318850


   Latest 1.0.1-SNAPSHOT here has a f ix you can test:
   https://repository.apache.org/content/repositories/snapshots/
   
   Note: This is NOT an official ASF release. It is provided solely for the purposes of testing this fix. Use it at your own risk. If you want to update the JAR in Tomcat 10 that does this migration at deployment time you want the shaded JAR.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox
In reply to this post by GitBox

ShamithaSIlva commented on issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841320652


   > Latest 1.0.1-SNAPSHOT here has a f ix you can test:
   > https://repository.apache.org/content/repositories/snapshots/
   >
   > Note: This is NOT an official ASF release. It is provided solely for the purposes of testing this fix. Use it at your own risk. If you want to update the JAR in Tomcat 10 that does this migration at deployment time you want the shaded JAR.
   
   Thanks will try this I thought it should work if I add .grovvy in supportedExtensions in TextConverter file. Will reply if this works with this snapshot


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox
In reply to this post by GitBox

rmaucher commented on issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841321964


   Yes, just add your extension here:
   https://github.com/apache/tomcat-jakartaee-migration/blob/master/src/main/java/org/apache/tomcat/jakartaee/TextConverter.java#L37


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox
In reply to this post by GitBox

ShamithaSIlva commented on issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841323483


   > Yes, just add your extension here:
   > https://github.com/apache/tomcat-jakartaee-migration/blob/master/src/main/java/org/apache/tomcat/jakartaee/TextConverter.java#L37
   
   Yes I suspected here and added the line let's see. thanks


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox
In reply to this post by GitBox

ShamithaSIlva commented on issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841338343


   Adding the extension on the file works:
   https://github.com/apache/tomcat-jakartaee-migration/blob/master/src/main/java/org/apache/tomcat/jakartaee/TextConverter.java#L37
   
   Thanks a lot guys!


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva closed issue #19: How can I add .groovy file support that do not get converted to .class files

GitBox
In reply to this post by GitBox

ShamithaSIlva closed issue #19:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]