[GitHub] [tomcat-maven-plugin] liudongmiao commented on a change in pull request #30: Tc9.x Initial suport for Tomact9

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-maven-plugin] liudongmiao commented on a change in pull request #30: Tc9.x Initial suport for Tomact9

GitBox

liudongmiao commented on a change in pull request #30:
URL: https://github.com/apache/tomcat-maven-plugin/pull/30#discussion_r459798227



##########
File path: tomcat9-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat9/run/RunMojo.java
##########
@@ -479,18 +480,23 @@ private WebResource urlToWebResource( URL url, String path )
                                 jarFile = new JarFile( filePath );
 
                                 JarEntry jarEntry = jarFile.getJarEntry( StringUtils.removeStart( path, "/" ) );
-
+/*
                                 return new JarResource( this, //
                                                         getPath(), //
                                                         filePath, //
                                                         url.getPath().substring( 0, idx ), //
                                                         jarEntry, //
                                                         "", //
                                                         null );
+                                */
+                                
+                                JarResourceSet jr = new JarResourceSet(context.getResources(), getPath(), filePath, getPath());

Review comment:
       Sorry for outdated.
   
   Yes, for the code, it's changed from `getPath()` to `"/"` in commit 7f26908685ee565c1a501ec7b03763905adf1b1b.
   And the internal path is always `"/"` now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]