[GitHub] [tomcat-native] michael-o opened a new pull request #7: BZ 64260: Clean up install target

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-native] michael-o opened a new pull request #7: BZ 64260: Clean up install target

GitBox
michael-o opened a new pull request #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7
 
 
   Remove bin/, include/, lib/pkgconfig/ from install target since they serve no
   purpose for the outside world and rather might confuse people. libtcnative is
   solely intended to be loaded dynamically from within the JVM and not be used
   as a library for other C clients.
   The archive cannot be easily removed w/o restructuring configure.ac and
   Makefile.in. The conceptual flaw is to rely on libtool generated for APR,
   rather than generating a libtool in-place with *_DISABLE_STATIC/*_PROG_LIBTOOL
   through autoreconf. A proper approach is taken by Subversion's build/ac-macros/apr.mk.
   
   Works flawlessly in-tree and out-of-tree build on FreeBSD, will test on HP-UX and RHEL 7.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-native] michael-o commented on issue #7: BZ 64260: Clean up install target

GitBox
michael-o commented on issue #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-603783395
 
 
   Works flawlessly on RHEL 7 and HP-UX 11.31.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-native] martin-g commented on issue #7: BZ 64260: Clean up install target

GitBox
In reply to this post by GitBox
martin-g commented on issue #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-605054606
 
 
   I will test this soon on Linux ARM64!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-native] michael-o commented on issue #7: BZ 64260: Clean up install target

GitBox
In reply to this post by GitBox
michael-o commented on issue #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-605156633
 
 
   > I will test this soon on Linux ARM64!
   
   Looking forward too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-native] martin-g commented on issue #7: BZ 64260: Clean up install target

GitBox
In reply to this post by GitBox
martin-g commented on issue #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-605859387
 
 
   Everything works fine on my Ubuntu 18.04.4 ARM64!
   The changes also look good to me but I am not an expert in this area.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat-native] michael-o commented on issue #7: BZ 64260: Clean up install target

GitBox
In reply to this post by GitBox
michael-o commented on issue #7: BZ 64260: Clean up install target
URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-605878034
 
 
   @martin-g Thanks. I will wait a couple of days for the other to look over eventually and will merge in April.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]