[GitHub] tomcat pull request #59: add some useful note

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomcat pull request #59: add some useful note

lkirchev
GitHub user powerYao opened a pull request:

    https://github.com/apache/tomcat/pull/59

    add some useful note

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/powerYao/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
   
----
commit ef498aad812cbaa9c25b044f302b0b108e24b4c6
Author: liYao <[hidden email]>
Date:   2017-06-05T11:52:20Z

    add note

commit 02403789f40ba7cfa685610e159bd5634cc3e0eb
Author: liYao <[hidden email]>
Date:   2017-06-05T22:57:38Z

    add code note

commit dfa5887860de92168be62a49bad5a96b35a34613
Author: liYao <[hidden email]>
Date:   2017-06-05T23:09:07Z

    add endpoint startAcceptorThreads note
   
    i think the startAcceptorThreads method should give a note to it. it's useful to
    beginner

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] tomcat issue #59: add some useful note

lkirchev
Github user markt-asf commented on the issue:

    https://github.com/apache/tomcat/pull/59
 
    Most added comments add no value. The s/poller/pollers/ change is the only one worth considering and that is a trivial change.
    The patch uses a mix of tabs and spaces for indents.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] tomcat pull request #59: add some useful note

lkirchev
In reply to this post by lkirchev
Github user asfgit closed the pull request at:

    https://github.com/apache/tomcat/pull/59


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] tomcat issue #59: add some useful note

lkirchev
In reply to this post by lkirchev
Github user powerYao commented on the issue:

    https://github.com/apache/tomcat/pull/59
 
    I get it,thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]