[GitHub] [tomcat] rmannibucau opened a new pull request #400: adding exitOnFirstListenerFailure flag in standardcontext to enable to stop at first listener error

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rmannibucau opened a new pull request #400: adding exitOnFirstListenerFailure flag in standardcontext to enable to stop at first listener error

GitBox

rmannibucau opened a new pull request #400:
URL: https://github.com/apache/tomcat/pull/400


   follow up of the list discussion, trying to propose a new flag.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rmaucher commented on pull request #400: adding exitOnFirstListenerFailure flag in standardcontext to enable to stop at first listener error

GitBox

rmaucher commented on pull request #400:
URL: https://github.com/apache/tomcat/pull/400#issuecomment-759479208


   Ideally, this should be resolved one way or the other by the specification. Also I noticed there is a failCtxIfServletStartFails attribute already, which can easily be abused without too many problems. This is for load on startup Servlets. Overall I don't think it's a great plan to add flags for everything.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rmannibucau commented on pull request #400: adding exitOnFirstListenerFailure flag in standardcontext to enable to stop at first listener error

GitBox
In reply to this post by GitBox

rmannibucau commented on pull request #400:
URL: https://github.com/apache/tomcat/pull/400#issuecomment-759482144


   @rmaucher agree it would be great if spec can clarifies it (in a way making the flag true OOTB ;)) but merging with the servlet flag is kind of different, listener being used to setup env (or symmetrically cleanup), you can need to go through them even if some fails (for auditing for ex) wheras servlets being the runtime it is often an all or none so guess we should keep both split.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rmannibucau edited a comment on pull request #400: adding exitOnFirstListenerFailure flag in standardcontext to enable to stop at first listener error

GitBox
In reply to this post by GitBox

rmannibucau edited a comment on pull request #400:
URL: https://github.com/apache/tomcat/pull/400#issuecomment-759482144


   @rmaucher agree it would be great if spec can clarifies it (in a way making the flag true OOTB ;)) but merging with the servlet flag is kind of different, listener being used to setup env (or symmetrically cleanup), you can need to go through them even if some fails (for auditing for ex) whereas servlets being the runtime it is often an all or none so guess we should keep both split.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] markt-asf commented on pull request #400: adding exitOnFirstListenerFailure flag in standardcontext to enable to stop at first listener error

GitBox
In reply to this post by GitBox

markt-asf commented on pull request #400:
URL: https://github.com/apache/tomcat/pull/400#issuecomment-759504799


   Can you expand on why this is an issue? The web application doesn't start either way and - generally - I think I'd prefer to see the scale of the problem (how many errors are there in total) rather than face an unknown number of repetitions of "start app, fails, fix error, repeat".
   I don't recall any EG discussion on this topic but 'll look to see if anything happened before my time or if I've forgotten something.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]