[GitHub] [tomcat] rotty3000 opened a new pull request #307: github actions

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 opened a new pull request #307: github actions

GitBox

rotty3000 opened a new pull request #307:
URL: https://github.com/apache/tomcat/pull/307


   Run github actions on branch pushes and PRs
   
   Signed-off-by: Raymond Augé <[hidden email]>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648392839


   This could be applied to each of the key branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648393296


   Also we can add to the matrix as we go.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] martin-g commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

martin-g commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648633491


   So far we have:
   1) Apache BuildBot as the official CI
   2) Travis - for testing non-x86_64 architectures (at the moment: aarch64 and s390x)
   
   Do we need a third CI ?
   Since GitHub Actions comes for free and there is nearly zero cost maintaining it I am fine to add it to the mix. But it might be confusing for someone.
   The pros are:
   * test on Windows
   * test PRs (this is the biggest issue I have with Apache BuildBot)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648856220


   I do not disagree that adding a third could be confusing. What I like about actions in addition to the points you've made is:
   
   - runs on forks as well (which means I can iterate with CI before even sending PR to main repo)
   - easily test full matrix of Java versions (including EAs, i.e. `15-ea`)
   - is super fast
   
   To differentiate between the official Apache BuildBot (which runs everything and takes very long because it is absolutely comprehensive) I was thinking to make use of github actions to be a form of soak test which builds all the main artifacts, on all supported Java versions, runs a small but comprehensive battery of tests, and runs a set of baseline tests against the 4 runtime assemblies:
   - **original** - catalina.sh on classpath
   - **embed** - need to figure out how to assemble this for run
   - **OSGi** - already have it locally
   - **jpms** - already have it locally
   
   Finally, i would like to see all that run in no more than 10 minutes to allow for pretty darn fast iterations with low risk of regression.
   
   As you can note in my change I've actually trimmed to run just the `nio` suite and disabled the openssl tests toward the goal of good testing but fast. Of course I need lots more input about what constitutes a comprehensive (yet fast) set of tests.
   
   Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648872489


   FYI, tomcat seems to build and test (nio) fine on Java 8, 11, 14 & 15-ea! :+1:


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-649013143


   FYI the latest iteration of this runs on Java 8 - 15-ea + windows in 11 minutes https://github.com/rotty3000/tomcat/actions/runs/146537422
   
   The arbitrary reduction was made by filtering all tests that take more than 5 seconds to run. The rest seem to make a reasonable smoke test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rmaucher commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rmaucher commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-649522279


   Looks good to me. Personally, I don't panic when I see a few random failures.
   
   Since this is meant as a smoke test, and in an effort to not spam too much about failures, I would do the following:
   - Only test trunk (development is supposed to happen there, so although there are backport problems sometimes, this is not that common and will be caught by the main CI rather quickly)
   - Use "test-nio", for some reason you use "test-nio2" which is not the default connector; but good idea on not testing all three connectors (or rather all six if you also include the JSSE/OpenSSL options
   - Exclude tests that need a long time to run


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-649530867


   @rmaucher I have made the requested changes:
   - only trunk
   - use nio
   - excluded tests slower than 5 seconds


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rmaucher commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rmaucher commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-649544386


   Nice, so it would seem it takes about 8 minutes now, down from 30 minutes initially. Eventually more "unimportant" tests could be excluded to get this down. I got confused with the "Container.tests" but that was just another branch name.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-650271782


   Is anyone up for merging this? If something is missing please let me know :) I wasn't sure if this warranted a changelog.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-650272578


   Also note that since this is handling push/pr on _master_ (to be renamed branch) there is no point applying this to other branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] martin-g merged pull request #307: github actions

GitBox
In reply to this post by GitBox

martin-g merged pull request #307:
URL: https://github.com/apache/tomcat/pull/307


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]