[GitHub] [tomcat] rotty3000 opened a new pull request #323: fix module names to reflect Jakarta EE origin

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 opened a new pull request #323: fix module names to reflect Jakarta EE origin

GitBox

rotty3000 opened a new pull request #323:
URL: https://github.com/apache/tomcat/pull/323


   Signed-off-by: Raymond Augé <[hidden email]>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #323: fix module names to reflect Jakarta EE origin

GitBox

rotty3000 commented on pull request #323:
URL: https://github.com/apache/tomcat/pull/323#issuecomment-658814002


   @markt-asf note there are distinct differences with this PR as I'm trying to follow the request you made in the Jakarta mailing list to use .api consistently. Also, in catalina, I was not sure about persistence name. Would it retain the `java.persistence` or follow the new jakarta "_convention_"?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] markt-asf commented on a change in pull request #323: fix module names to reflect Jakarta EE origin

GitBox
In reply to this post by GitBox

markt-asf commented on a change in pull request #323:
URL: https://github.com/apache/tomcat/pull/323#discussion_r458009648



##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
         access=32;\
         version=${Bundle-Version};\
         modules='\
-            jakarta.ejb-api,\
-            jakarta.mail,\
-            jakarta.persistence-api,\
-            jakarta.xml.rpc-api,\
-            java.xml.ws'
+            jakarta.ejb.api,\
+            jakarta.mail.api,\

Review comment:
       Jakarta Mail has opted for `jakarta.mail`

##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
         access=32;\
         version=${Bundle-Version};\
         modules='\
-            jakarta.ejb-api,\
-            jakarta.mail,\
-            jakarta.persistence-api,\
-            jakarta.xml.rpc-api,\
-            java.xml.ws'
+            jakarta.ejb.api,\
+            jakarta.mail.api,\
+            jakarta.persistence.api,\
+            jakarta.xml.rpc.api,\
+            jakarta.xml.ws.api'

Review comment:
       Jakarta XMl WS opted for `jakarta.xml.ws`

##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
         access=32;\
         version=${Bundle-Version};\
         modules='\
-            jakarta.ejb-api,\
-            jakarta.mail,\
-            jakarta.persistence-api,\
-            jakarta.xml.rpc-api,\
-            java.xml.ws'
+            jakarta.ejb.api,\

Review comment:
       Jakarta Enterprise Beans 4.0.0-RC2  does not define a module name so I think we are OK with this for now.

##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
         access=32;\
         version=${Bundle-Version};\
         modules='\
-            jakarta.ejb-api,\
-            jakarta.mail,\
-            jakarta.persistence-api,\
-            jakarta.xml.rpc-api,\
-            java.xml.ws'
+            jakarta.ejb.api,\
+            jakarta.mail.api,\
+            jakarta.persistence.api,\

Review comment:
       Jakarta Persistence has opted for `jakarta.persistence`

##########
File path: res/bnd/jaspic-api.jar.tmp.bnd
##########
@@ -35,9 +35,9 @@ Provide-Capability: \
     Implementation-Vendor=Apache Software Foundation
 
 -jpms-module-info: \
-    jakarta.security.enterprise;\
+    jakarta.security.enterprise.api;\

Review comment:
       The most recent RC (2.0.0-RC2) doesn't define a module name so this should be OK for now.

##########
File path: res/bnd/annotations-api.jar.tmp.bnd
##########
@@ -35,9 +35,9 @@ Provide-Capability: \
     Implementation-Vendor=Apache Software Foundation
 
 -jpms-module-info: \
-    jakarta.annotation;\
+    jakarta.annotation.api;\
         access=32;\
         version=${annotation.spec.version}
 -jpms-module-info-options: \
-    jakarta.annotation;\
+    jakarta.annotation.api;\
         substitute=annotations-api

Review comment:
       This change is not required. Jakarta Annotation API has chosen `jakarta.annotation`

##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
         access=32;\
         version=${Bundle-Version};\
         modules='\
-            jakarta.ejb-api,\
-            jakarta.mail,\
-            jakarta.persistence-api,\
-            jakarta.xml.rpc-api,\
-            java.xml.ws'
+            jakarta.ejb.api,\
+            jakarta.mail.api,\
+            jakarta.persistence.api,\
+            jakarta.xml.rpc.api,\

Review comment:
       XML RPC has been dropped in Jakarta EE 9. We'll need to clean that up in Tomcat. I guess this one can stay as is for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #323: fix module names to reflect Jakarta EE origin

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #323:
URL: https://github.com/apache/tomcat/pull/323#issuecomment-661903666


   See updates.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] markt-asf commented on pull request #323: fix module names to reflect Jakarta EE origin

GitBox
In reply to this post by GitBox

markt-asf commented on pull request #323:
URL: https://github.com/apache/tomcat/pull/323#issuecomment-662032441


   Heads up. The Jakarta EE JPMS names are currently a moving target. At least one person thinks there is a policy that the JPMS names should not have the ".api" on the end. I am trying to get clarification on the position because as far as I am aware there is no official policy. We have plenty of time so I suggest we wait for Jakarta EE to stabilise and then align our names with theirs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] rotty3000 commented on pull request #323: fix module names to reflect Jakarta EE origin

GitBox
In reply to this post by GitBox

rotty3000 commented on pull request #323:
URL: https://github.com/apache/tomcat/pull/323#issuecomment-662054802


   I saw :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] markt-asf closed pull request #323: fix module names to reflect Jakarta EE origin

GitBox
In reply to this post by GitBox

markt-asf closed pull request #323:
URL: https://github.com/apache/tomcat/pull/323


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomcat] markt-asf commented on pull request #323: fix module names to reflect Jakarta EE origin

GitBox
In reply to this post by GitBox

markt-asf commented on pull request #323:
URL: https://github.com/apache/tomcat/pull/323#issuecomment-730329196


   This has been addressed in 10.0.x and 9.0.x. Note there nay be another change for 10.1.x depending on what naming convention Jakarta EE adopts.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]