Initial set of patches for Jakarta EE 9

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Initial set of patches for Jakarta EE 9

Mark Thomas-2
Hi all,

I have pushed an initial set of patches for Jakarta EE 9 here:
https://github.com/markt-asf/tomcat/tree/jakarta

The current status is:
- All the packages changing in Jakarta EE 9 have been renamed
- Any associated constants, service loader files etc. have also been
  renamed
- It builds
- The unit tests pass (excluding those that depend on JSTL - more on
  that below)
- A basic smoke test passes

Please try and build it, take it for a spin and report back on this
thread if you find any issues.

Right, JSTL. I don't particularly want us to have to produce a Jakarta
EE version of JSTL. So, I plan to use this as the first test case for my
"Java EE to Jakarta EE converter". I've only just started work on this
so I don't have any real progress to report. I hope to make progress on
this next week.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Initial set of patches for Jakarta EE 9

remm
On Thu, Nov 28, 2019 at 8:46 PM Mark Thomas <[hidden email]> wrote:
Hi all,

I have pushed an initial set of patches for Jakarta EE 9 here:
https://github.com/markt-asf/tomcat/tree/jakarta

The current status is:
- All the packages changing in Jakarta EE 9 have been renamed
- Any associated constants, service loader files etc. have also been
  renamed
- It builds
- The unit tests pass (excluding those that depend on JSTL - more on
  that below)
- A basic smoke test passes

Please try and build it, take it for a spin and report back on this
thread if you find any issues.

Right, JSTL. I don't particularly want us to have to produce a Jakarta
EE version of JSTL. So, I plan to use this as the first test case for my
"Java EE to Jakarta EE converter". I've only just started work on this
so I don't have any real progress to report. I hope to make progress on
this next week.

Works quite well already, I have the following items:
- java/org/apache/tomcat/util/http/RequestUtil.java uses a javax.
- test/org/apache/tomcat/util/http/TestRequestUtilSameOrigin.java uses two javax.

The testsuite passes without the need for any additional fixes.

So that's excellent, too bad I didn't get to do anything.

Rémy

Reply | Threaded
Open this post in threaded view
|

Re: Initial set of patches for Jakarta EE 9

Igal Sapir-2
In reply to this post by Mark Thomas-2
Mark,

On 11/28/2019 11:46 AM, Mark Thomas wrote:

> Hi all,
>
> I have pushed an initial set of patches for Jakarta EE 9 here:
> https://github.com/markt-asf/tomcat/tree/jakarta
>
> The current status is:
> - All the packages changing in Jakarta EE 9 have been renamed
> - Any associated constants, service loader files etc. have also been
>    renamed
> - It builds
> - The unit tests pass (excluding those that depend on JSTL - more on
>    that below)
> - A basic smoke test passes
>
> Please try and build it, take it for a spin and report back on this
> thread if you find any issues.

First issue I noticed when trying to build on Windows:

compile:
     [javac] Compiling 1727 source files to
E:\Workspace\test\tomcat-jakarta\output\classes
     [javac]
E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:21:
error: package javax.servlet.http does not exist
     [javac] import javax.servlet.http.HttpServletRequest;
     [javac]                          ^
     [javac]
E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:122:
error: cannot find symbol
     [javac]     public static boolean isSameOrigin(HttpServletRequest
request, String origin) {
     [javac]                                        ^
     [javac]   symbol:   class HttpServletRequest
     [javac]   location: class RequestUtil
     [javac] Note: Some input files use or override a deprecated API.
     [javac] Note: Recompile with -Xlint:deprecation for details.
     [javac] 2 errors

BUILD FAILED
E:\Workspace\test\tomcat-jakarta\build.xml:706: Compile failed; see the
compiler error output for details.

Igal



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Initial set of patches for Jakarta EE 9

Mark Thomas-2
On 30/11/2019 21:11, Igal Sapir wrote:

> Mark,
>
> On 11/28/2019 11:46 AM, Mark Thomas wrote:
>> Hi all,
>>
>> I have pushed an initial set of patches for Jakarta EE 9 here:
>> https://github.com/markt-asf/tomcat/tree/jakarta
>>
>> The current status is:
>> - All the packages changing in Jakarta EE 9 have been renamed
>> - Any associated constants, service loader files etc. have also been
>>    renamed
>> - It builds
>> - The unit tests pass (excluding those that depend on JSTL - more on
>>    that below)
>> - A basic smoke test passes
>>
>> Please try and build it, take it for a spin and report back on this
>> thread if you find any issues.
>
> First issue I noticed when trying to build on Windows:
>
> compile:
>     [javac] Compiling 1727 source files to
> E:\Workspace\test\tomcat-jakarta\output\classes
>     [javac]
> E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:21:
> error: package javax.servlet.http does not exist
>     [javac] import javax.servlet.http.HttpServletRequest;
>     [javac]                          ^
>     [javac]
> E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:122:
> error: cannot find symbol
>     [javac]     public static boolean isSameOrigin(HttpServletRequest
> request, String origin) {
>     [javac]                                        ^
>     [javac]   symbol:   class HttpServletRequest
>     [javac]   location: class RequestUtil
>     [javac] Note: Some input files use or override a deprecated API.
>     [javac] Note: Recompile with -Xlint:deprecation for details.
>     [javac] 2 errors
>
> BUILD FAILED
> E:\Workspace\test\tomcat-jakarta\build.xml:706: Compile failed; see the
> compiler error output for details.

Sorry. My error. When I rebased the branch I forgot to check if any
additional changes were required. I've fixed this now. Note I used a
force push to try and keep to the one commit per package I used originally.

Should be OK now.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Initial set of patches for Jakarta EE 9

Igal Sapir-2
On 12/1/2019 1:28 PM, Mark Thomas wrote:

> On 30/11/2019 21:11, Igal Sapir wrote:
>
> <snip/>
>> First issue I noticed when trying to build on Windows:
>>
>> compile:
>>      [javac] Compiling 1727 source files to
>> E:\Workspace\test\tomcat-jakarta\output\classes
>>      [javac]
>> E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:21:
>> error: package javax.servlet.http does not exist
>>      [javac] import javax.servlet.http.HttpServletRequest;
>>      [javac]                          ^
>>      [javac]
>> E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:122:
>> error: cannot find symbol
>>      [javac]     public static boolean isSameOrigin(HttpServletRequest
>> request, String origin) {
>>      [javac]                                        ^
>>      [javac]   symbol:   class HttpServletRequest
>>      [javac]   location: class RequestUtil
>>      [javac] Note: Some input files use or override a deprecated API.
>>      [javac] Note: Recompile with -Xlint:deprecation for details.
>>      [javac] 2 errors
>>
>> BUILD FAILED
>> E:\Workspace\test\tomcat-jakarta\build.xml:706: Compile failed; see the
>> compiler error output for details.
> Sorry. My error. When I rebased the branch I forgot to check if any
> additional changes were required. I've fixed this now. Note I used a
> force push to try and keep to the one commit per package I used originally.
>
> Should be OK now.

This one built fine but got some failing test cases on a busy Windows
machine, so possibly false positives:

    [concat] Testsuites with failed tests:
    [concat]
TEST-org.apache.catalina.authenticator.TestFormAuthenticator.APR.txt
    [concat] TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt
    [concat] TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt
    [concat] TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt
    [concat] TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt
    [concat] TEST-org.apache.jasper.runtime.TestJspRuntimeLibrary.APR.txt
    [concat] TEST-org.apache.jasper.runtime.TestJspRuntimeLibrary.NIO.txt
    [concat] TEST-org.apache.jasper.runtime.TestJspRuntimeLibrary.NIO2.txt
    [concat]
TEST-org.apache.tomcat.websocket.TestWebSocketFrameClientSSL.APR.txt

Igal




---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]