[VOTE] Release Apache Tomcat 7.0.83

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Tomcat 7.0.83

Violeta Georgieva
The proposed Apache Tomcat 7.0.83 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.83/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1163/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_83/

The proposed 7.0.83 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.83 Stable

Regards,
Violeta
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Huxing Zhang
Hi,

The proposed 7.0.83 release is:
[ ] Broken - do not release
[ X ] Stable - go ahead and release as 7.0.83 Stable

Unit test passed on JDK6
Examples: ok
Our test web application runs fine.

One thing that I want to confirm is:

I use Java 9 to build the source code, however it failed with the following message:

build:
    [javac] Compiling 32 source files to /Users/huxing/work/apache-tomcat/tomcat7/trunk/output/jdbc-pool/classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
    [javac] error: Source option 1.5 is no longer supported. Use 1.6 or later.
    [javac] error: Target option 1.5 is no longer supported. Use 1.6 or later.

BUILD FAILED
/Users/huxing/work/apache-tomcat/tomcat7/trunk/build.xml:1077: The following error occurred while executing this line:
/Users/huxing/work/apache-tomcat/tomcat7/trunk/modules/jdbc-pool/build.xml:153: Compile failed; see the compiler error output for details.

I've checked the modules/jdbc-pool/build.properties.default, the default compile source/target level is 1.5.

Changing compile source/target to 1.6 will solve this issue.

However, the compile source/target of jdbc-pool conforms to the minimal Java version tomcat requires in tomcat 8 (1.7), tomcat 8.5 (1.7), and tomcat 9(1.8).

Therefore I think it might be a bug of tomcat 7.



------------------------------------------------------------------
Violeta Georgieva <[hidden email]>
2017 Dec 1 (Fri) 03:37
Tomcat Developers List <[hidden email]>
[VOTE] Release Apache Tomcat 7.0.83


The proposed Apache Tomcat 7.0.83 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.83/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1163/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_83/

The proposed 7.0.83 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.83 Stable

Regards,
Violeta
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Felix Schumacher
In reply to this post by Violeta Georgieva


Am 30. November 2017 20:37:12 MEZ schrieb Violeta Georgieva <[hidden email]>:

>The proposed Apache Tomcat 7.0.83 release is now available for voting.
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.83/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1163/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_83/
>
>The proposed 7.0.83 release is:
>[ ] Broken - do not release
>[x] Stable - go ahead and release as 7.0.83 Stable

Felix

>
>Regards,
>Violeta

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Violeta Georgieva
In reply to this post by Violeta Georgieva
Hi,

We need more votes here

Thanks,
Violeta


On Thu, 30 Nov 2017 at 11:37, Violeta Georgieva <[hidden email]>
wrote:

> The proposed Apache Tomcat 7.0.83 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.83/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1163/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_83/
>
> The proposed 7.0.83 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.83 Stable
>
> Regards,
> Violeta
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Coty Sutherland
In reply to this post by Violeta Georgieva
On Thu, Nov 30, 2017 at 2:37 PM, Violeta Georgieva <[hidden email]> wrote:

> The proposed Apache Tomcat 7.0.83 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.83/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1163/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_83/
>
> The proposed 7.0.83 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.83 Stable

+1

> Regards,
> Violeta

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Konstantin Kolinko
In reply to this post by Violeta Georgieva
2017-11-30 22:37 GMT+03:00 Violeta Georgieva <[hidden email]>:

> The proposed Apache Tomcat 7.0.83 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.83/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1163/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_83/
>
> The proposed 7.0.83 release is:
> [x] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.83 Stable

1. Unit tests - OK. Tested BIO,NIO,APR(32-bit) with Java 6, 7, 8u152.

The following test fails with 8u152, regardless of connector:
org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream
[[[
Testcase: testBug52121 took 0,025 sec
    Caused an ERROR
invalid code lengths set
java.util.zip.ZipException: invalid code lengths set
    at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
    at java.util.zip.GZIPInputStream.read(GZIPInputStream.java:117)
    at java.io.FilterInputStream.read(FilterInputStream.java:107)
    at org.apache.catalina.util.IOTools.flow(IOTools.java:74)
    at org.apache.catalina.util.IOTools.flow(IOTools.java:85)
    at org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream.testBug52121(TestFlushableGZIPOutputStream.java:74)
]]]

This is the known regression of Java 8u151/152. It is not a bug in Tomcat.

2. I smoke-tested running with compression enabled and Java 8u152.
Generally, it looks OK.

3. There is an issue noted when testing the Async example, I filed it
into bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61886

It needs further investigation.
I am voting "Broken" because of it.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Rainer Jung-3
Hi Konstantin,

Am 11.12.2017 um 12:30 schrieb Konstantin Kolinko:
...

> The following test fails with 8u152, regardless of connector:
> org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream
> [[[
> Testcase: testBug52121 took 0,025 sec
>      Caused an ERROR
> invalid code lengths set
> java.util.zip.ZipException: invalid code lengths set
>      at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
>      at java.util.zip.GZIPInputStream.read(GZIPInputStream.java:117)
>      at java.io.FilterInputStream.read(FilterInputStream.java:107)
>      at org.apache.catalina.util.IOTools.flow(IOTools.java:74)
>      at org.apache.catalina.util.IOTools.flow(IOTools.java:85)
>      at org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream.testBug52121(TestFlushableGZIPOutputStream.java:74)
> ]]]
>
> This is the known regression of Java 8u151/152. It is not a bug in Tomcat.

I can reproduce, but shouldn't that have been fixed in r1816712 and
r1816713? Or is our test class just not using the workaround, so the
test is broken?

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Konstantin Kolinko
2017-12-11 15:37 GMT+03:00 Rainer Jung <[hidden email]>:

> Hi Konstantin,
>
> Am 11.12.2017 um 12:30 schrieb Konstantin Kolinko:
> ...
>>
>> The following test fails with 8u152, regardless of connector:
>> org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream
>> [[[
>> Testcase: testBug52121 took 0,025 sec
>>      Caused an ERROR
>> invalid code lengths set
>> java.util.zip.ZipException: invalid code lengths set
>>      at
>> java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
>>      at java.util.zip.GZIPInputStream.read(GZIPInputStream.java:117)
>>      at java.io.FilterInputStream.read(FilterInputStream.java:107)
>>      at org.apache.catalina.util.IOTools.flow(IOTools.java:74)
>>      at org.apache.catalina.util.IOTools.flow(IOTools.java:85)
>>      at
>> org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream.testBug52121(TestFlushableGZIPOutputStream.java:74)
>> ]]]
>>
>> This is the known regression of Java 8u151/152. It is not a bug in Tomcat.
>
>
> I can reproduce, but shouldn't that have been fixed in r1816712 and
> r1816713? Or is our test class just not using the workaround, so the test is
> broken?

Nothing is broken here.
I am just noting for an archive that JRE bug is visible here.
(It is a pity that nobody tested an early build of 8u151 with 7.0.x.
They could have seen the bug.)

The test tests FlushableGZIPOutputStream directly. That class is not
used when running on Java 7+.
I manually tested that Tomcat runs correctly with compression enabled.


My concern with 7.0.83 is error handling in async (bug 61886).

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 7.0.83

Rainer Jung-3
Am 11.12.2017 um 14:02 schrieb Konstantin Kolinko:

> 2017-12-11 15:37 GMT+03:00 Rainer Jung <[hidden email]>:
>> Hi Konstantin,
>>
>> Am 11.12.2017 um 12:30 schrieb Konstantin Kolinko:
>> ...
>>>
>>> The following test fails with 8u152, regardless of connector:
>>> org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream
>>> [[[
>>> Testcase: testBug52121 took 0,025 sec
>>>       Caused an ERROR
>>> invalid code lengths set
>>> java.util.zip.ZipException: invalid code lengths set
>>>       at
>>> java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
>>>       at java.util.zip.GZIPInputStream.read(GZIPInputStream.java:117)
>>>       at java.io.FilterInputStream.read(FilterInputStream.java:107)
>>>       at org.apache.catalina.util.IOTools.flow(IOTools.java:74)
>>>       at org.apache.catalina.util.IOTools.flow(IOTools.java:85)
>>>       at
>>> org.apache.coyote.http11.filters.TestFlushableGZIPOutputStream.testBug52121(TestFlushableGZIPOutputStream.java:74)
>>> ]]]
>>>
>>> This is the known regression of Java 8u151/152. It is not a bug in Tomcat.
>>
>>
>> I can reproduce, but shouldn't that have been fixed in r1816712 and
>> r1816713? Or is our test class just not using the workaround, so the test is
>> broken?
>
> Nothing is broken here.
> I am just noting for an archive that JRE bug is visible here.
> (It is a pity that nobody tested an early build of 8u151 with 7.0.x.
> They could have seen the bug.)
>
> The test tests FlushableGZIPOutputStream directly. That class is not
> used when running on Java 7+.
> I manually tested that Tomcat runs correctly with compression enabled.

Thanks for confirming.

> My concern with 7.0.83 is error handling in async (bug 61886).

Understood.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]