[VOTE] Release Apache Tomcat 8.5.47

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Tomcat 8.5.47

markt
The proposed Apache Tomcat 8.5.47 release is now available for voting.

The major changes compared to the 8.5.46 release are:

- Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
  Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
  running on a Windows OS that had not been fully updated.

- Fix some edge cases with NIO2 and TLS that could has a request to
  hang.


Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.47/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1234/

The tag is:
https://github.com/apache/tomcat/tree/8.5.47
14bdacea996993a3b94ec0972cea92370e42ae4d

The proposed 8.5.47 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.47

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

Rémy Maucherat
On Mon, Oct 7, 2019 at 3:58 PM Mark Thomas <[hidden email]> wrote:
The proposed Apache Tomcat 8.5.47 release is now available for voting.

The major changes compared to the 8.5.46 release are:

- Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
  Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
  running on a Windows OS that had not been fully updated.

- Fix some edge cases with NIO2 and TLS that could has a request to
  hang.


Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.47/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1234/

The tag is:
https://github.com/apache/tomcat/tree/8.5.47
14bdacea996993a3b94ec0972cea92370e42ae4d

The proposed 8.5.47 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.47

Rémy
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

Igal Sapir-2
In reply to this post by markt
On 10/7/2019 6:58 AM, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.47 release is now available for voting.
>
> The major changes compared to the 8.5.46 release are:

I'm getting similar test failures as I did for 9.0.27 on that same
Windows machine:

 > grep -A 5 FAILED output/build/logs/*.txt
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri:
/stage1, Status: 500, Time: 2248 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 2248 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorWithThreadMultiple(TestAsyncContextImpl.java:921)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri:
/stage1, Status: 500, Time: 4018 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 4018 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorMultiple(TestAsyncContextImpl.java:906)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri:
/stage1, Status: 500, Time: 2182 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 2182 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorDoubleThenComplete(TestAsyncContextImpl.java:931)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri:
/stage1, Status: 500, Time: 2512 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 2512 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorSingle(TestAsyncContextImpl.java:896)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri:
/stage1, Status: 500, Time: 1843 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 1843 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorWithThreadMultipleThenComplete(TestAsyncContextImpl.java:954)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri:
/stage1, Status: 500, Time: 2499 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 2499 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorMultipleThenComplete(TestAsyncContextImpl.java:936)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-Uri:
/stage1, Status: 500, Time: 2852 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 2852 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorWithThreadMultiple(TestAsyncContextImpl.java:921)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-Uri:
/stage1, Status: 500, Time: 5203 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 5203 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorMultiple(TestAsyncContextImpl.java:906)
--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt:
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-Uri:
/stage1, Status: 500, Time: 2927 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-junit.framework.AssertionFailedError:
Uri: /stage1, Status: 500, Time: 2927 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt-
at
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorWithThreadSingle(TestAsyncContextImpl.java:911)
--
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt:
FAILED
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-expected:<...3-Header-[:status]-[[304]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[date]-[W...>
but was:<...3-Header-[:status]-[[200]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[accept-ranges]-[bytes]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt:
FAILED
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-expected:<...3-Header-[:status]-[[304]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[etag]-[W/"957-1447269522000"]]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[date]-[W...>
but was:<...3-Header-[:status]-[[200]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[accept-ranges]-[bytes]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt:
FAILED
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-expected:<...3-Header-[:status]-[[304]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[etag]-[W/"957-1447269522000"]]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[date]-[W...>
but was:<...3-Header-[:status]-[[200]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[accept-ranges]-[bytes]
output/build/logs/TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[etag]-[W/"957-1447269522000"]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

markt
On 08/10/2019 17:19, Igal Sapir wrote:
> On 10/7/2019 6:58 AM, Mark Thomas wrote:
>> The proposed Apache Tomcat 8.5.47 release is now available for voting.
>>
>> The major changes compared to the 8.5.46 release are:
>
> I'm getting similar test failures as I did for 9.0.27 on that same
> Windows machine:

These also look like timing issues.

I see TestAsyncContextImpl test failures like this fairly frequently on VMs.

The other failures look to be the same as the 9.0.x tests.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

Michael Osipov
In reply to this post by markt
Am 2019-10-07 um 15:58 schrieb Mark Thomas:

> The proposed Apache Tomcat 8.5.47 release is now available for voting.
>
> The major changes compared to the 8.5.46 release are:
>
> - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
>    Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
>    running on a Windows OS that had not been fully updated.
>
> - Fix some edge cases with NIO2 and TLS that could has a request to
>    hang.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.47/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1234/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.47
> 14bdacea996993a3b94ec0972cea92370e42ae4d

+1

Though I see some minor failures I have not investigated yet

> $ java -version
> openjdk version "1.8.0_222"
> OpenJDK Runtime Environment (build 1.8.0_222-b10)
> OpenJDK 64-Bit Server VM (build 25.222-b10, mixed mode)
> $ uname -a
> FreeBSD deblndw011x.ad001.siemens.net 12.0-STABLE FreeBSD 12.0-STABLE #0 r351324: Wed Aug 21 15:47:48 CEST 2019     [hidden email]:/usr/obj/usr/src/amd64.amd64/sys/DEBLNDW011X  amd64

in
> /var/osipovmi/Projekte/tomcat/output/build/logs/TEST-org.apache.catalina.nonblocking.TestNonBlockingAPI.NIO.txt
> /var/osipovmi/Projekte/tomcat/output/build/logs/TEST-org.apache.catalina.nonblocking.TestNonBlockingAPI.NIO2.txt
> /var/osipovmi/Projekte/tomcat/output/build/logs/TEST-org.apache.coyote.http2.TestHttp2InitialConnection.*.txt
> /var/osipovmi/Projekte/tomcat/output/build/logs/TEST-org.apache.coyote.http2.TestHttp2Limits.*.txt

with

> Testcase: testNonBlockingWriteError took 33,493 sec
>     FAILED
> Uri: /, Status: 500, Time: 33456 duration is not < 30600
> junit.framework.AssertionFailedError: Uri: /, Status: 500, Time: 33456 duration is not < 30600
>     at org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
>     at org.apache.catalina.nonblocking.TestNonBlockingAPI.testNonBlockingWriteError(TestNonBlockingAPI.java:380)

and

> Testcase: testMultipleHostHeaders took 1,385 sec
>     FAILED
> expected:<...content-length]-[112[7]
> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
> 1-HeadersEnd
> 1-Body-1127]
> 1-EndOfStream
>> but was:<...content-length]-[112[8]
> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
> 1-HeadersEnd
> 1-Body-1128]
> 1-EndOfStream
>>
> junit.framework.AssertionFailedError: expected:<...content-length]-[112[7]
> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
> 1-HeadersEnd
> 1-Body-1127]
> 1-EndOfStream
>> but was:<...content-length]-[112[8]
> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
> 1-HeadersEnd
> 1-Body-1128]
> 1-EndOfStream
>>
>     at org.apache.coyote.http2.Http2TestBase.validateHttp2InitialResponse(Http2TestBase.java:129)
>     at org.apache.coyote.http2.Http2TestBase.http2Connect(Http2TestBase.java:111)
>     at org.apache.coyote.http2.TestHttp2InitialConnection.testMultipleHostHeaders(TestHttp2InitialConnection.java:55)
>
> Testcase: testValidHostHeader took 0,143 sec
> Testcase: testNoHostHeader took 0,185 sec
>     FAILED
> expected:<...content-length]-[112[7]
> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
> 1-HeadersEnd
> 1-Body-1127]
> 1-EndOfStream
>> but was:<...content-length]-[112[8]
> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
> 1-HeadersEnd
> 1-Body-1128]
> 1-EndOfStream
>>
 > ...

and the last one is a locale issue with the resource bundles:

> 08-Oct-2019 11:24:51.852 INFORMATION [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["http-apr-127.0.0.1-auto-24-26939"]
> ------------- ---------------- ---------------
>
> Testcase: testHeaderLimits100x32 took 1,391 sec
> Testcase: testHeaderLimits101x32 took 0,411 sec
> Testcase: testHeaderLimits1x128k took 0,416 sec
>     FAILED
>
> Expected: match to regular expression pattern [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>      but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3], Gesamt-Header-Größe zu groß]"
> junit.framework.AssertionFailedError:
> Expected: match to regular expression pattern [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>      but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3], Gesamt-Header-Größe zu groß]"
>     at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
>     at org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:259)
>     at org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:170)
>     at org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:164)
>     at org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:158)
>     at org.apache.coyote.http2.TestHttp2Limits.testHeaderLimits1x128k(TestHttp2Limits.java:138)

Michael


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

markt
On 09/10/2019 16:48, Michael Osipov wrote:

<snip/>

> Though I see some minor failures I have not investigated yet

<snip/>

> with
>
>> Testcase: testNonBlockingWriteError took 33,493 sec
>>     FAILED
>> Uri: /, Status: 500, Time: 33456 duration is not < 30600
>> junit.framework.AssertionFailedError: Uri: /, Status: 500, Time: 33456
>> duration is not < 30600
>>     at
>> org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
>>
>>     at
>> org.apache.catalina.nonblocking.TestNonBlockingAPI.testNonBlockingWriteError(TestNonBlockingAPI.java:380)

Timing issues like this are generally safe to ignore. We see sporadic
failures with these, especially on loaded systems.

> and
>
>> Testcase: testMultipleHostHeaders took 1,385 sec
>>     FAILED
>> expected:<...content-length]-[112[7]
>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>> 1-HeadersEnd
>> 1-Body-1127]
>> 1-EndOfStream
>>> but was:<...content-length]-[112[8]
>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>> 1-HeadersEnd
>> 1-Body-1128]
>> 1-EndOfStream
>>>
>> junit.framework.AssertionFailedError:
>> expected:<...content-length]-[112[7]
>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>> 1-HeadersEnd
>> 1-Body-1127]
>> 1-EndOfStream
>>> but was:<...content-length]-[112[8]
>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>> 1-HeadersEnd
>> 1-Body-1128]
>> 1-EndOfStream
>>>
>>     at
>> org.apache.coyote.http2.Http2TestBase.validateHttp2InitialResponse(Http2TestBase.java:129)
>>
>>     at
>> org.apache.coyote.http2.Http2TestBase.http2Connect(Http2TestBase.java:111)
>>
>>     at
>> org.apache.coyote.http2.TestHttp2InitialConnection.testMultipleHostHeaders(TestHttp2InitialConnection.java:55)
>>
>>
>> Testcase: testValidHostHeader took 0,143 sec
>> Testcase: testNoHostHeader took 0,185 sec
>>     FAILED
>> expected:<...content-length]-[112[7]
>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>> 1-HeadersEnd
>> 1-Body-1127]
>> 1-EndOfStream
>>> but was:<...content-length]-[112[8]
>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>> 1-HeadersEnd
>> 1-Body-1128]
>> 1-EndOfStream

Hmm. Those are odd. I wonder why the content length is off. Some sort of
line ending issue maybe?

> and the last one is a locale issue with the resource bundles:
>
>> 08-Oct-2019 11:24:51.852 INFORMATION [main]
>> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
>> ["http-apr-127.0.0.1-auto-24-26939"]
>> ------------- ---------------- ---------------
>>
>> Testcase: testHeaderLimits100x32 took 1,391 sec
>> Testcase: testHeaderLimits101x32 took 0,411 sec
>> Testcase: testHeaderLimits1x128k took 0,416 sec
>>     FAILED
>>
>> Expected: match to regular expression pattern
>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>>      but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3],
>> Gesamt-Header-Größe zu groß]"
>> junit.framework.AssertionFailedError:
>> Expected: match to regular expression pattern
>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>>      but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3],
>> Gesamt-Header-Größe zu groß]"
>>     at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
>>     at
>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:259)
>>
>>     at
>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:170)
>>
>>     at
>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:164)
>>
>>     at
>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:158)
>>
>>     at
>> org.apache.coyote.http2.TestHttp2Limits.testHeaderLimits1x128k(TestHttp2Limits.java:138)

We should find a way to fix that one.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

Michael Osipov
Am 2019-10-09 um 18:55 schrieb Mark Thomas:

> On 09/10/2019 16:48, Michael Osipov wrote:
>> and
>>
>>> Testcase: testMultipleHostHeaders took 1,385 sec
>>>      FAILED
>>> expected:<...content-length]-[112[7]
>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>> 1-HeadersEnd
>>> 1-Body-1127]
>>> 1-EndOfStream
>>>> but was:<...content-length]-[112[8]
>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>> 1-HeadersEnd
>>> 1-Body-1128]
>>> 1-EndOfStream
>>>>
>>> junit.framework.AssertionFailedError:
>>> expected:<...content-length]-[112[7]
>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>> 1-HeadersEnd
>>> 1-Body-1127]
>>> 1-EndOfStream
>>>> but was:<...content-length]-[112[8]
>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>> 1-HeadersEnd
>>> 1-Body-1128]
>>> 1-EndOfStream
>>>>
>>>      at
>>> org.apache.coyote.http2.Http2TestBase.validateHttp2InitialResponse(Http2TestBase.java:129)
>>>
>>>      at
>>> org.apache.coyote.http2.Http2TestBase.http2Connect(Http2TestBase.java:111)
>>>
>>>      at
>>> org.apache.coyote.http2.TestHttp2InitialConnection.testMultipleHostHeaders(TestHttp2InitialConnection.java:55)
>>>
>>>
>>> Testcase: testValidHostHeader took 0,143 sec
>>> Testcase: testNoHostHeader took 0,185 sec
>>>      FAILED
>>> expected:<...content-length]-[112[7]
>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>> 1-HeadersEnd
>>> 1-Body-1127]
>>> 1-EndOfStream
>>>> but was:<...content-length]-[112[8]
>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>> 1-HeadersEnd
>>> 1-Body-1128]
>>> 1-EndOfStream
>
> Hmm. Those are odd. I wonder why the content length is off. Some sort of
> line ending issue maybe?

I assume so. I will look into it.

>> and the last one is a locale issue with the resource bundles:
>>
>>> 08-Oct-2019 11:24:51.852 INFORMATION [main]
>>> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
>>> ["http-apr-127.0.0.1-auto-24-26939"]
>>> ------------- ---------------- ---------------
>>>
>>> Testcase: testHeaderLimits100x32 took 1,391 sec
>>> Testcase: testHeaderLimits101x32 took 0,411 sec
>>> Testcase: testHeaderLimits1x128k took 0,416 sec
>>>      FAILED
>>>
>>> Expected: match to regular expression pattern
>>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>>>       but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3],
>>> Gesamt-Header-Größe zu groß]"
>>> junit.framework.AssertionFailedError:
>>> Expected: match to regular expression pattern
>>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>>>       but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3],
>>> Gesamt-Header-Größe zu groß]"
>>>      at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
>>>      at
>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:259)
>>>
>>>      at
>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:170)
>>>
>>>      at
>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:164)
>>>
>>>      at
>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:158)
>>>
>>>      at
>>> org.apache.coyote.http2.TestHttp2Limits.testHeaderLimits1x128k(TestHttp2Limits.java:138)
>
> We should find a way to fix that one.

Either exclude the resource JARs from the classpath or change the code.
Shall I file an issue here?

Michael


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

markt
On 09/10/2019 21:35, Michael Osipov wrote:

> Am 2019-10-09 um 18:55 schrieb Mark Thomas:
>> On 09/10/2019 16:48, Michael Osipov wrote:
>>> and
>>>
>>>> Testcase: testMultipleHostHeaders took 1,385 sec
>>>>      FAILED
>>>> expected:<...content-length]-[112[7]
>>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>>> 1-HeadersEnd
>>>> 1-Body-1127]
>>>> 1-EndOfStream
>>>>> but was:<...content-length]-[112[8]
>>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>>> 1-HeadersEnd
>>>> 1-Body-1128]
>>>> 1-EndOfStream
>>>>>
>>>> junit.framework.AssertionFailedError:
>>>> expected:<...content-length]-[112[7]
>>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>>> 1-HeadersEnd
>>>> 1-Body-1127]
>>>> 1-EndOfStream
>>>>> but was:<...content-length]-[112[8]
>>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>>> 1-HeadersEnd
>>>> 1-Body-1128]
>>>> 1-EndOfStream
>>>>>
>>>>      at
>>>> org.apache.coyote.http2.Http2TestBase.validateHttp2InitialResponse(Http2TestBase.java:129)
>>>>
>>>>
>>>>      at
>>>> org.apache.coyote.http2.Http2TestBase.http2Connect(Http2TestBase.java:111)
>>>>
>>>>
>>>>      at
>>>> org.apache.coyote.http2.TestHttp2InitialConnection.testMultipleHostHeaders(TestHttp2InitialConnection.java:55)
>>>>
>>>>
>>>>
>>>> Testcase: testValidHostHeader took 0,143 sec
>>>> Testcase: testNoHostHeader took 0,185 sec
>>>>      FAILED
>>>> expected:<...content-length]-[112[7]
>>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>>> 1-HeadersEnd
>>>> 1-Body-1127]
>>>> 1-EndOfStream
>>>>> but was:<...content-length]-[112[8]
>>>> 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT]
>>>> 1-HeadersEnd
>>>> 1-Body-1128]
>>>> 1-EndOfStream
>>
>> Hmm. Those are odd. I wonder why the content length is off. Some sort of
>> line ending issue maybe?
>
> I assume so. I will look into it.

Thanks.

>>> and the last one is a locale issue with the resource bundles:
>>>
>>>> 08-Oct-2019 11:24:51.852 INFORMATION [main]
>>>> org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
>>>> ["http-apr-127.0.0.1-auto-24-26939"]
>>>> ------------- ---------------- ---------------
>>>>
>>>> Testcase: testHeaderLimits100x32 took 1,391 sec
>>>> Testcase: testHeaderLimits101x32 took 0,411 sec
>>>> Testcase: testHeaderLimits1x128k took 0,416 sec
>>>>      FAILED
>>>>
>>>> Expected: match to regular expression pattern
>>>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>>>>       but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3],
>>>> Gesamt-Header-Größe zu groß]"
>>>> junit.framework.AssertionFailedError:
>>>> Expected: match to regular expression pattern
>>>> [0-Goaway-\[1\]-\[11\]-\[Connection \[\d++\], Stream \[3\], .*]
>>>>       but: was "0-Goaway-[1]-[11]-[Verbindung [2], Stream [3],
>>>> Gesamt-Header-Größe zu groß]"
>>>>      at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
>>>>      at
>>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:259)
>>>>
>>>>
>>>>      at
>>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:170)
>>>>
>>>>
>>>>      at
>>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:164)
>>>>
>>>>
>>>>      at
>>>> org.apache.coyote.http2.TestHttp2Limits.doTestHeaderLimits(TestHttp2Limits.java:158)
>>>>
>>>>
>>>>      at
>>>> org.apache.coyote.http2.TestHttp2Limits.testHeaderLimits1x128k(TestHttp2Limits.java:138)
>>>>
>>
>> We should find a way to fix that one.
>
> Either exclude the resource JARs from the classpath or change the code.
> Shall I file an issue here?

Yes please.

I was thinking of using StringManager to obtain the i18n version of the
string for the test. I haven't look to see whether that is practical or not.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

Konstantin Kolinko
In reply to this post by markt
пн, 7 окт. 2019 г. в 16:58, Mark Thomas <[hidden email]>:
>
> The proposed Apache Tomcat 8.5.47 release is now available for voting.
>
>
> The proposed 8.5.47 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.47

Unit tests - OK. Smoke tests - OK. Installing, uninstalling (on Windows) - OK.
I tested on Windows 10 with Java 7u80 (32-bit), 13u0 (64-bit) from
Oracle, 8u222 (64-bit) from AdoptOpenJDK.

Best regards.
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Tomcat 8.5.47

markt
In reply to this post by markt
On 07/10/2019 14:58, Mark Thomas wrote:

> The proposed 8.5.47 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.47

Unit tests pass for NIO, NIO2 and APR/native with Tomcat Native 1.2.23
on Linux, Windows and MacOS.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[VOTE][RESULT] Release Apache Tomcat 8.5.47

markt
In reply to this post by markt
The following votes were cast:

Binding:
+1: remm, michaelo, kkolinko, markt

No other votes were cast.

This vote therefore passes.

Thanks to everyone who contributed to this release.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]