[tomcat] branch 9.0.x updated: SpotBugs - update false positives for SpotBugs 4.1.4

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[tomcat] branch 9.0.x updated: SpotBugs - update false positives for SpotBugs 4.1.4

markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 1dfc27f  SpotBugs - update false positives for SpotBugs 4.1.4
1dfc27f is described below

commit 1dfc27fbd3a0b93b780b7b682deb0115b8691d77
Author: Mark Thomas <[hidden email]>
AuthorDate: Fri Oct 16 17:56:11 2020 +0100

    SpotBugs - update false positives for SpotBugs 4.1.4
---
 res/findbugs/filter-false-positives.xml | 62 +++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/res/findbugs/filter-false-positives.xml b/res/findbugs/filter-false-positives.xml
index c62e9ac..9b8b32a 100644
--- a/res/findbugs/filter-false-positives.xml
+++ b/res/findbugs/filter-false-positives.xml
@@ -17,6 +17,11 @@
 <FindBugsFilter>
   <!--  Considered to be false positives -->
   <Match>
+    <!-- Generated by compiler -->
+    <Field name="~\$SWITCH_TABLE\$.*"/>
+    <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+  </Match>
+  <Match>
     <!-- Only base null is handled by this resolver -->
     <Class name="javax.el.BeanNameELResolver"/>
     <Or>
@@ -541,6 +546,12 @@
     <Bug code="NP" />
   </Match>
   <Match>
+    <!-- Domain resolution not an issue here -->
+    <Class name="org.apache.catalina.startup.WebappServiceLoader" />
+    <Method name="load" />
+    <Bug pattern="DMI_COLLECTION_OF_URLS" />
+  </Match>
+  <Match>
     <!-- If old -> save worked, assume save -> old will to -->
     <Class name="org.apache.catalina.storeconfig.StoreFileMover" />
     <Method name="move" />
@@ -702,6 +713,12 @@
     <Bug code="RCN"/>
   </Match>
   <Match>
+    <!-- Syncs are there to protect state not context -->
+    <Class name="org.apache.catalina.valves.HealthCheckValve" />
+    <Field name="context" />
+    <Bug pattern="IS2_INCONSISTENT_SYNC" />
+  </Match>
+  <Match>
     <!-- Non-constant strings are configuration settings rather than client
          supplied -->
     <Class name="org.apache.catalina.valves.JDBCAccessLogValve" />
@@ -709,6 +726,15 @@
     <Bug code="SQL" />
   </Match>
   <Match>
+    <!-- NO-OPs due to remaining FIXMEs -->
+    <Class name="org.apache.catalina.valves.rewrite.ResolverImpl"/>
+    <Method name="resolveSsl"/>
+    <Or>
+      <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
+      <Bug pattern="RV_RETURN_VALUE_IGNORED"/>
+    </Or>
+  </Match>
+  <Match>
     <!-- request.getQueryString() can be null because
     o.a.t.util.buf.MessageBytes.toString() can return NULL -->
     <Class name="org.apache.catalina.valves.rewrite.RewriteValve"/>
@@ -1026,6 +1052,12 @@
     </Or>
   </Match>
   <Match>
+    <!-- Sync protects writing not reading -->
+    <Class name="org.apache.tomcat.dbcp.dbcp2.BasicDataSource" />
+    <Field name="closed" />
+    <Bug pattern="IS2_INCONSISTENT_SYNC" />
+  </Match>
+  <Match>
     <!-- Return value is never used -->
     <Class name="org.apache.tomcat.dbcp.dbcp2.DelegatingConnection" />
     <Method name="prepareStatement" />
@@ -1318,6 +1350,12 @@
     <Bug code="SF" />
   </Match>
   <Match>
+    <!-- Returns null by design -->
+    <Class name="org.apache.tomcat.util.http.parser.EntityTag" />
+     <Method name="compareEntityTag"/>
+    <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+  </Match>
+  <Match>
     <!-- Reader instance always accepts -ve skip values and there is -->
     <!-- always enough space to skip back the requested amount.      -->
     <Class name="org.apache.tomcat.util.http.parser.HttpParser" />
@@ -1879,6 +1917,15 @@
     <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
   </Match>
   <Match>
+    <!-- Return values are irrelevant as exceptions should be thrown -->
+    <Class name="org.apache.catalina.webresources.TestJarContents"/>
+    <Or>
+      <Method name="testStringOutOfBoundExceptions"/>
+      <Method name="testNullPointerExceptions"/>
+    </Or>
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>
+  </Match>
+  <Match>
     <!-- Use of hard-coded path is deliberate -->
     <Class name="org.apache.catalina.webresources.TestStandardRoot" />
     <Method name="&lt;clinit&gt;" />
@@ -1906,6 +1953,12 @@
     <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
   </Match>
   <Match>
+    <!-- Test code - and e3choing a header should be safe anyway -->
+    <Class name="org.apache.coyote.http11.upgrade.TestUpgrade$UpgradeServlet"/>
+    <Method name="doGet"/>
+    <Bug pattern="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER"/>
+  </Match>
+  <Match>
     <!-- Latch isn't essential so no need to check return -->
     <Class name="org.apache.coyote.http2.TestAsyncTimeout"/>
     <Method name="testTimeout"/>
@@ -2110,6 +2163,12 @@
     </Or>
   </Match>
   <Match>
+    <!-- Array contents is not mutated -->
+    <Class name="org.apache.tomcat.websocket.pojo.TestEncodingDecoding$MsgByte"/>
+    <Field name="data"/>
+    <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+  </Match>
+  <Match>
     <!-- Return value of latch is intentionally ignored -->
     <Or>
       <Class name="org.apache.tomcat.websocket.TestWebSocketFrameClient"/>
@@ -2149,6 +2208,9 @@
       <Method name="testEgMailingList04" />
       <Method name="testEgMailingList05" />
       <Method name="testQuote2" />
+      <Method name="testSpecIssue194a" />
+      <Method name="testSpecIssue194b" />
+      <Method name="testSpecIssue194c" />
     </Or>
     <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
   </Match>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]