tomcat-native include directory name

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

tomcat-native include directory name

csutherl
Hi all,

Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
include directory instead of tomcat-native? I just pushed
http://svn.apache.org/r1849428 so that make now copies the header files
into _includedir, and noticed that the directory is named 'apr' rather than
'tomcat-native'.

$ grep includedir native/config.layout
    includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
    includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
    includedir:    ${prefix}/include
    includedir:    ${prefix}/include+
    includedir:
/System/Library/Frameworks/apr.framework/Versions/2.0/Headers
    includedir:    ${prefix}/include+
    includedir:    ${prefix}/include/apr
    includedir:    ${prefix}/include
    includedir:    ${prefix}/include
    includedir:    ${prefix}/include/apr
    includedir:    ${exec_prefix}/include/apr
    includedir:    ${exec_prefix}/include
    includedir:    ${exec_prefix}/lib/apr/include
    includedir:    ${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}



Thanks,
Coty
Reply | Threaded
Open this post in threaded view
|

Re: tomcat-native include directory name

markt
On 20/12/2018 19:51, Coty Sutherland wrote:
> Hi all,
>
> Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
> include directory instead of tomcat-native? I just pushed
> http://svn.apache.org/r1849428 so that make now copies the header files
> into _includedir, and noticed that the directory is named 'apr' rather than
> 'tomcat-native'.

If I had to guess, I'd say because the original file was copied from APR
and that part was never changed.

Mark


>
> $ grep includedir native/config.layout
>     includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
>     includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
>     includedir:    ${prefix}/include
>     includedir:    ${prefix}/include+
>     includedir:
> /System/Library/Frameworks/apr.framework/Versions/2.0/Headers
>     includedir:    ${prefix}/include+
>     includedir:    ${prefix}/include/apr
>     includedir:    ${prefix}/include
>     includedir:    ${prefix}/include
>     includedir:    ${prefix}/include/apr
>     includedir:    ${exec_prefix}/include/apr
>     includedir:    ${exec_prefix}/include
>     includedir:    ${exec_prefix}/lib/apr/include
>     includedir:    ${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
>
>
>
> Thanks,
> Coty
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: tomcat-native include directory name

csutherl
On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas <[hidden email]> wrote:

> On 20/12/2018 19:51, Coty Sutherland wrote:
> > Hi all,
> >
> > Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
> > include directory instead of tomcat-native? I just pushed
> > http://svn.apache.org/r1849428 so that make now copies the header files
> > into _includedir, and noticed that the directory is named 'apr' rather
> than
> > 'tomcat-native'.
>
> If I had to guess, I'd say because the original file was copied from APR
> and that part was never changed.
>

Should fixing that be considered a breaking change and therefore trigger a
minor update instead of a revision? Or can I just change it and move on
with life? :)


>
> Mark
>
>
> >
> > $ grep includedir native/config.layout
> >     includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> >     includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> >     includedir:    ${prefix}/include
> >     includedir:    ${prefix}/include+
> >     includedir:
> > /System/Library/Frameworks/apr.framework/Versions/2.0/Headers
> >     includedir:    ${prefix}/include+
> >     includedir:    ${prefix}/include/apr
> >     includedir:    ${prefix}/include
> >     includedir:    ${prefix}/include
> >     includedir:    ${prefix}/include/apr
> >     includedir:    ${exec_prefix}/include/apr
> >     includedir:    ${exec_prefix}/include
> >     includedir:    ${exec_prefix}/lib/apr/include
> >     includedir:    ${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> >
> >
> >
> > Thanks,
> > Coty
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: tomcat-native include directory name

markt
On 08/01/2019 19:53, Coty Sutherland wrote:

> On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas <[hidden email]> wrote:
>
>> On 20/12/2018 19:51, Coty Sutherland wrote:
>>> Hi all,
>>>
>>> Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
>>> include directory instead of tomcat-native? I just pushed
>>> http://svn.apache.org/r1849428 so that make now copies the header files
>>> into _includedir, and noticed that the directory is named 'apr' rather
>> than
>>> 'tomcat-native'.
>>
>> If I had to guess, I'd say because the original file was copied from APR
>> and that part was never changed.
>>
>
> Should fixing that be considered a breaking change and therefore trigger a
> minor update instead of a revision? Or can I just change it and move on
> with life? :)

What could break if you changed this? Isn't it a build time thing rather
than a run time thing?

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: tomcat-native include directory name

Coty Sutherland
On Tue, Jan 8, 2019 at 7:06 PM Mark Thomas <[hidden email]> wrote:

> On 08/01/2019 19:53, Coty Sutherland wrote:
> > On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas <[hidden email]> wrote:
> >
> >> On 20/12/2018 19:51, Coty Sutherland wrote:
> >>> Hi all,
> >>>
> >>> Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
> >>> include directory instead of tomcat-native? I just pushed
> >>> http://svn.apache.org/r1849428 so that make now copies the header
> files
> >>> into _includedir, and noticed that the directory is named 'apr' rather
> >> than
> >>> 'tomcat-native'.
> >>
> >> If I had to guess, I'd say because the original file was copied from APR
> >> and that part was never changed.
> >>
> >
> > Should fixing that be considered a breaking change and therefore trigger
> a
> > minor update instead of a revision? Or can I just change it and move on
> > with life? :)
>
> What could break if you changed this? Isn't it a build time thing rather
> than a run time thing?
>

You're right. I was thinking of this with my package maintainer hat on,
however after checking the package it doesn't depend on that directory
specifically so I think I'm free to correct it.


>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>